Require minimum 24 hour window for PR reviews #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it already in the documentation https://docs.qgis.org/latest/en/docs/developers_guide/git.html#pull-requests-merge-criteria ? |
|
@agiudiceandrea that was unofficially added -- if you look at the original proposal at #304, it was never voted/approved on. |
|
@agiudiceandrea see also qgis/QGIS-Documentation#9699, where I removed that content |
|
+1 |
4 similar comments
|
+1 |
|
+1 |
|
+1 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal adds a new 24 hour minimum window for PR reviews to QEP 323.
This was originally proposed by @rouault in #303 (comment), and is intended to allow wider feedback to be gathered prior to merges, and to permit pre-merge feedback from developers in other time zones.
Fixes #304
(If we decide to adopt this policy, we could possibly use the "minimum open time" GitHub action to enforce it. See https://github.com/gregsdennis/minimum-open-time. An example repo using this action is https://github.com/json-schema-org/json-schema-spec)