Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DPG badge to the homepage and the README #563

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Feb 19, 2025

Fix for #547

image

image

@anitagraser
Copy link
Member

The Readme badge is good. I'm OK with that.

The badge on the home page needs some more work:

  1. It's now visually more prominent than the "open source" badge, but that does not reflect the true importance. The visual impact of DPG should be <= open source.
  2. On a related note: the outline of the DPG batch should be the same width (or thinner) than the open source badge's outline.
  3. The DPG badge's blue shades does not match any of our colors. This makes it look very jarring. Can we have a b/w version?
  4. Finally, my OCD is triggered by the outline "cutting off" the white circle on the left: image It just doesn't feel aligned correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image needs some padding on the left, so that the circle on the left is properly displayed

@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 19, 2025

Thank you very much for the review @anitagraser.

  • I've updated it using the white version and reviewed the design.
  • I've also decreased the opacity to 80% to make it less attractive.
  • The left padding of the image has been adjusted to make the circle appear correctly
  • The outline has been adjusted to match the width of the Free and Open Source label

What do you think about this?

image

Here is a zoomed-in version:

image

@anitagraser
Copy link
Member

Much better, thanks. Maybe 70% opacity for the image to match the outline more closely.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Feb 20, 2025

The outline and the badge opacity are now aligned
image

@anitagraser
Copy link
Member

Perfect. Good to merge for me

@Xpirix Xpirix merged commit 3ddfc06 into qgis:main Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants