Skip to content

Commit

Permalink
Minor changes per review
Browse files Browse the repository at this point in the history
  • Loading branch information
dvdkon committed Dec 2, 2024
1 parent 16058f4 commit 44d5399
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ struct QgsPointCloudAttributeStatistics
double mean;
double stDev;
int count;

int singleClassCount( int cls ) const;
%Docstring
Returns the count of points in given class or -1 on error

.. versionadded:: 3.42
%End
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,12 @@ struct QgsPointCloudAttributeStatistics
double mean;
double stDev;
int count;

int singleClassCount( int cls ) const;
%Docstring
Returns the count of points in given class or -1 on error

.. versionadded:: 3.42
%End
};

Expand Down
4 changes: 2 additions & 2 deletions src/core/pointcloud/qgscopcpointcloudindex.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class CORE_EXPORT QgsCopcPointCloudIndex: public QgsPointCloudIndex
void load( const QString &fileName ) override;

bool hasNode( const QgsPointCloudNodeId &n ) const override;
virtual QgsPointCloudNode getNode( const QgsPointCloudNodeId &id ) const override;
QgsPointCloudNode getNode( const QgsPointCloudNodeId &id ) const override;

std::unique_ptr< QgsPointCloudBlock> nodeData( const QgsPointCloudNodeId &n, const QgsPointCloudRequest &request ) override;
QgsPointCloudBlockRequest *asyncNodeData( const QgsPointCloudNodeId &n, const QgsPointCloudRequest &request ) override;
Expand All @@ -76,7 +76,7 @@ class CORE_EXPORT QgsCopcPointCloudIndex: public QgsPointCloudIndex
* If the dataset doesn't contain statistics EVLR, an object with 0 samples will be returned.
* \since QGIS 3.42
*/
virtual QgsPointCloudStatistics metadataStatistics() const override;
QgsPointCloudStatistics metadataStatistics() const override;

/**
* Copies common properties to the \a destination index
Expand Down
4 changes: 2 additions & 2 deletions src/core/pointcloud/qgseptpointcloudindex.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ class CORE_EXPORT QgsEptPointCloudIndex: public QgsPointCloudIndex

QgsCoordinateReferenceSystem crs() const override;
qint64 pointCount() const override;
virtual QgsPointCloudNode getNode( const QgsPointCloudNodeId &id ) const override;
QgsPointCloudNode getNode( const QgsPointCloudNodeId &id ) const override;
QVariantMap originalMetadata() const override { return mOriginalMetadata; }
virtual QgsPointCloudStatistics metadataStatistics() const override;
QgsPointCloudStatistics metadataStatistics() const override;

bool isValid() const override;
QgsPointCloudIndex::AccessType accessType() const override;
Expand Down
6 changes: 5 additions & 1 deletion src/core/pointcloud/qgspointcloudstatistics.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,11 @@ struct CORE_EXPORT QgsPointCloudAttributeStatistics
//! Updates the current point cloud statistics to hold the cumulation of the current statistics and \a stats
void cumulateStatistics( const QgsPointCloudAttributeStatistics &stats );
#endif
//! Returns the count of points in given class or -1 on error

/**
* Returns the count of points in given class or -1 on error
* \since QGIS 3.42
*/
int singleClassCount( int cls ) const;
};

Expand Down

0 comments on commit 44d5399

Please sign in to comment.