[snapping] Invalidate the filtered layer tree model when a parent group switches from empty/non-empty state #59668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
added
backport queued_ltr_backports
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
…up switches from empty/non-empty state
nirvn
force-pushed
the
snapping_layers_model_fix
branch
from
d0b7cf5 to
10b8875
Compare
nyalldawson
approved these changes
Dec 2, 2024
This was referenced Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #59469 whereas creating a new group and moving layers into that group doesn't show in the advanced snapping layer tree widget.
The layers are hidden as the snapping layer tree model filters out empty group. When children are added into the group, the filtered model didn't invalidate its filter, resulting in both the group and the added children gone missing from the tree widget.