-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds clang-format to pre-commit to 3.40 #59677
Conversation
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
@3nids I'm not really sure what I'm supposed to be using to auto-format anymore. I understood that pre-commit should be formatting all files not exposed to sip, and astyle for the rest (for now). But I only see pre-commit format some files, and the rest are just unchanged (eg editing a .cpp file in src/raster) |
@nyalldawson have you done https://github.com/qgis/QGIS-Documentation/blob/master/docs/developers_guide/git.rst#procedure |
@3nids Maybe it's worth posting what needs to be changed to the devs mailing list |
Yep. Something's definitely wonky -- try editing a cpp file in src/core, and neither scripts/prepare-commit.sh nor pre-commit run will apply any formatting change to it. |
@nyalldawson I was quite sure I tested this... fixed here https://github.com/qgis/QGIS/pull/59713/files?w=1 |
manual backport of #59664
run pre-commit on all files which was not done yet on this branch