Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Source Manager STAC extras #59690

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

uclaros
Copy link
Contributor

@uclaros uclaros commented Dec 2, 2024

Description

This is a followup of #59534

It adds the following functionality to the STAC page in data source manager:

  • Display footprints of the search results items in the map canvas
  • Highlight selected item's footprint
  • Allow hiding the footprints

Peek 2024-12-02 10-08

Also adds in the Items' context menu:

  • Zoom to Item option
  • Pan to Item option
  • Option to add a single Asset as a Layer
  • Option to download the item's Assets
    Screenshot_20241202_100434

For downloading assets, the same dialog is used as the one in the browser implementation
image

@github-actions github-actions bot added this to the 3.42.0 milestone Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

🪟 Windows builds

Download Windows builds of this PR for testing.
Debug symbols for this build are available here.
(Built from commit 97784cb)

🪟 Windows Qt6 builds

Download Windows Qt6 builds of this PR for testing.
(Built from commit 97784cb)

@uclaros uclaros added the STAC Related to SpatioTemporal Asset Catalog label Dec 2, 2024
@saberraz
Copy link
Contributor

saberraz commented Dec 3, 2024

I have tested the PR and have some suggestions to improve the usability:

  • Activate the gray screen only when user sets a spatial or temporal filter (see the screencast below)
  • De-activate the gray screen when filters are removed
  • Make the gray layer is more transparent so, user can still see the canvas contents
    data browser

@uclaros
Copy link
Contributor Author

uclaros commented Dec 3, 2024

Your "Grey Screen" seems to be 250 overlapping footprints, spanning the whole world (-180, +180, -90, +90)!
Footprints are 50% transparent so the map below can be visible, but in this case, 250 stacked footprints blocked the whole canvas!
You should be able to disable them by unticking the Show footprints checkbox.

Maybe we should skip showing those whole-world-footprints, or show a single one regardless of the number of items that have one.

@saberraz
Copy link
Contributor

saberraz commented Dec 3, 2024

That makes sense, thanks for the clarification and pointing me to the footprint checkbox. Please ignore the comment, as all seems to be working as expected.

@wonder-sk wonder-sk merged commit 7528ca6 into qgis:master Dec 3, 2024
31 checks passed
@uclaros uclaros deleted the stac-dsm-extras branch December 3, 2024 14:56
@DelazJ DelazJ added Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Dec 6, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Dec 6, 2024

@uclaros
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Dec 6, 2024

@uclaros
A documentation ticket has been opened at qgis/QGIS-Documentation#9451
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Dec 6, 2024

@uclaros

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. STAC Related to SpatioTemporal Asset Catalog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants