clang-format on src/gui + fix windows builds #59760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3nids
changed the title
🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. 🪟 Windows buildsDownload Windows builds of this PR for testing. |
nyalldawson
reviewed
Dec 5, 2024
python/PyQt6/gui/auto_generated/maptools/qgsmaptoolcapture.sip.in
Outdated
Show resolved
Hide resolved
python/PyQt6/gui/auto_generated/maptools/qgsmaptooldigitizefeature.sip.in
Outdated
Show resolved
Hide resolved
python/PyQt6/gui/auto_generated/proj/qgsprojectionselectionwidget.sip.in
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
3nids
force-pushed
the
clang-format-gui
branch
from
c786550 to
a5f37ce
Compare
nyalldawson
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, using
SIP_TYPEHEADER_INCLUDE( xxx.h )seems to be failing on MingW builds:https://github.com/qgis/QGIS/actions/runs/12181752788/job/33979118401#step:12:866
I don't understand why it was not caught in #59691 (https://github.com/qgis/QGIS/actions/runs/12155138928/job/33896100592)
I also tried
SIP_TYPEHEADER_INCLUDE( "xxx.h" ):https://github.com/qgis/QGIS/actions/runs/12182336466/job/33981099900#step:12:867
I don't see any other option than putting comment in front for now.