BUG: Fix metadata:plugin_dependencies parsing #59852
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When writing a plugin, adding multiple values to the
plugin_depencies
field of themetadata.txt
raises false positive errors when whitespaces are inserted in the line. One is supposed to split dependencies using a,
comma, but if whitespaces are inserted (which is the 'standard' syntax ... at least in python with pip) it missread the name (false leading/trailling whitespaces).This patch only commits a
.strip()
addition to the name and version parsedExemple
current behavior:
plugin_dependencies = Plugin Reloader, QRestart
# failsplugin_dependencies = Plugin Reloader,QRestart
# successpatched behavior:
plugin_dependencies = Plugin Reloader, QRestart
# successplugin_dependencies = Plugin Reloader,QRestart
# success