Disable broken test for automatic transaction groups on GDAL >= 3.5 #59910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
This functionality is broken on newer GDAL versions, due to incorrect assumptions at time of development. See qgis#59797 (comment) Parties interested in seeing this test resurrected are welcome to submit fixes.
nyalldawson
force-pushed
the
disable_broken_test
branch
from
48a2478 to
636e1a5
Compare
nyalldawson
changed the title
|
Ok, given discussion on the qgis-dev list this is now just disabling the test for GDAL >= 3.5, pending a fix in GDAL itself. |
rouault
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is broken on newer GDAL versions, due to incorrect assumptions at time of development.
See #59797 (comment)
Parties interested in seeing this functionality resurrected (i.e. not me) are welcome to submit fixes to the broken transaction handling logic.