Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize download #401

Merged
merged 8 commits into from
Oct 24, 2023
Merged

optimize download #401

merged 8 commits into from
Oct 24, 2023

Conversation

YangSen-qn
Copy link
Contributor

@YangSen-qn YangSen-qn commented Sep 22, 2023

变更背景描述

当用户指定了下载域名,那么就仅使用用户指定的域名进行下载

jira issue链接

KODO-18923

主要变更点

  • fix bug
  • new feature
  • 不兼容变更

Checklist

  • 已自测
  • 已更新Readme

@qiniu-bot
Copy link
Collaborator

Hi @YangSen-qn. Thanks for your PR.

I'm waiting for a qiniu member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiniu-bot qiniu-bot added size/L and removed size/XS labels Sep 22, 2023
@YangSen-qn YangSen-qn changed the title optimize get account optimize download Sep 22, 2023
@qiniu-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bachue, YangSen-qn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #401 (5d71747) into master (180cb0f) will decrease coverage by 0.11%.
Report is 9 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 5d71747 differs from pull request most recent head dd6e8ea. Consider uploading reports for the commit dd6e8ea to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
- Coverage   12.18%   12.07%   -0.11%     
==========================================
  Files          24       24              
  Lines        1116     1126      +10     
==========================================
  Hits          136      136              
- Misses        957      967      +10     
  Partials       23       23              
Files Coverage Δ
iqshell/common/utils/utils.go 18.67% <0.00%> (-0.35%) ⬇️
iqshell/common/utils/crypto.go 0.00% <0.00%> (ø)
iqshell/common/utils/file.go 8.57% <0.00%> (-0.19%) ⬇️

@bachue bachue merged commit 4f8719b into qiniu:master Oct 24, 2023
@YangSen-qn YangSen-qn deleted the nfs branch October 26, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants