Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batchsign & batchstat support output to file #403

Merged
merged 15 commits into from
Nov 1, 2023

Conversation

YangSen-qn
Copy link
Contributor

@YangSen-qn YangSen-qn commented Oct 26, 2023

变更背景描述

jira issue链接

KODO-19014

主要变更点

  • fix bug
  • new feature
  • 不兼容变更

Checklist

  • 已自测
  • 已更新Readme

@qiniu-prow
Copy link

qiniu-prow bot commented Oct 26, 2023

Hi @YangSen-qn. Thanks for your PR.

I'm waiting for a qiniu member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiniu-prow qiniu-prow bot added the size/M label Oct 26, 2023
@YangSen-qn
Copy link
Contributor Author

/ok-to-test

@qiniu-prow
Copy link

qiniu-prow bot commented Oct 26, 2023

@YangSen-qn: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CarlJi
Copy link
Contributor

CarlJi commented Oct 26, 2023

/ok-to-test

@qiniu-prow qiniu-prow bot added size/L and removed size/M labels Oct 26, 2023
@qiniu-prow
Copy link

qiniu-prow bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bachue, YangSen-qn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiniu-prow qiniu-prow bot added the approved label Oct 26, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #403 (8105093) into master (4f8719b) will not change coverage.
The diff coverage is n/a.

❗ Current head 8105093 differs from pull request most recent head c8d03eb. Consider uploading reports for the commit c8d03eb to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   12.07%   12.07%           
=======================================
  Files          24       24           
  Lines        1126     1126           
=======================================
  Hits          136      136           
  Misses        967      967           
  Partials       23       23           

@bachue bachue merged commit 9a3432b into qiniu:master Nov 1, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants