Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: align common practice #453

Merged
merged 1 commit into from
Nov 20, 2024
Merged

chore: align common practice #453

merged 1 commit into from
Nov 20, 2024

Conversation

CarlJi
Copy link
Contributor

@CarlJi CarlJi commented Nov 18, 2024

No description provided.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for reviewbot-x canceled.

Name Link
🔨 Latest commit 03150a3
🔍 Latest deploy log https://app.netlify.com/sites/reviewbot-x/deploys/673d5d84669993000868ae69

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 1.55642% with 253 lines in your changes missing coverage. Please review.

Project coverage is 26.41%. Comparing base (9473eab) to head (03150a3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server.go 0.00% 233 Missing ⚠️
config/config.go 28.57% 7 Missing and 3 partials ⚠️
internal/linters/providergitlab.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
+ Coverage   25.72%   26.41%   +0.69%     
==========================================
  Files          31       31              
  Lines        4459     4350     -109     
==========================================
+ Hits         1147     1149       +2     
+ Misses       3176     3063     -113     
- Partials      136      138       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

server.go Show resolved Hide resolved
server.go Show resolved Hide resolved
server.go Show resolved Hide resolved
server.go Show resolved Hide resolved
@CarlJi CarlJi force-pushed the feat/token branch 3 times, most recently from c648a90 to 4d425a5 Compare November 20, 2024 03:45
@CarlJi CarlJi merged commit 36f0f76 into qiniu:master Nov 20, 2024
7 of 8 checks passed
@CarlJi CarlJi deleted the feat/token branch November 20, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant