feat(log): make Lmodule option as deprecated and add Lintermediatefile model to enhance log library #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 77.85% 71.70% -6.15%
==========================================
Files 23 24 +1
Lines 1644 1930 +286
==========================================
+ Hits 1280 1384 +104
- Misses 324 499 +175
- Partials 40 47 +7 ☔ View full report in Codecov by Sentry. |
CarlJi
force-pushed
the
log_enhance
branch
2 times, most recently
from
2ab2da3 to
1fd3ac7
Compare
xushiwei
reviewed
Dec 10, 2023
CarlJi
changed the title
xushiwei
reviewed
Dec 14, 2023
log/logext.go
Outdated
| Lshortfile // final file name element and line number: d.go:23. overrides Llongfile | ||
| // Deprecated: recommend to use Lintermediatefile option instead. | ||
| Lmodule // module name | ||
| Lintermediatefile // final file format output is typically in the format c/d.go:23, which includes the last two paths. If the compilation includes the '-trimpath' parameter, this format will just exclude the module path prefix. |
There was a problem hiding this comment.
don't change values of existed symbols such as Llevel.
…g usage in the old way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly focus:
StdLogger.Now, when using the Std logger, the output prefix will look like the following, which includes the last two path elements of the file. This change aims to make it more IDE-friendly.
Additionally, if the compilation includes the
-trimpathparameter, the output prefix will exclude the module path prefix, resulting in a cleaner file path display.