ci: updates some linting rules #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mypy did not run in CI at all - black was not run on the docs folder I also updated the rules in the Makefile to respect the currently active Python environment (by prepending the `python -m`). This was also done in Qiskit Nature a while back.
More to come from Elena soon... 🙂
Merged
mrossinek
requested review from
Cryoris,
woodsp-ibm and
ElePT
as code owners
woodsp-ibm
reviewed
Sep 8, 2023
Comment on lines
-98
to
+99
| parameter_sets: Sequence[set[Parameter]], | ||
| parameter_sets: Sequence[Sequence[Parameter]], |
There was a problem hiding this comment.
Seeing this again here I finally commented maybe this needs further investigation. Given its called parameter_sets and a set having unique values in it, unlike Sequence - maybe it has never really been treated as a set or needed to be one. If it were assumed so and this now has duplicates, which maybe a test never covered (CI passes). @a-matsuo any comment/thought here.
woodsp-ibm
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I also updated the rules in the Makefile to respect the currently active Python environment (by prepending the
python -m). This was also done in Qiskit Nature a while back.Details and comments