Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default t_span available for DynamicsBackend.solve #353

Merged
merged 5 commits into from
Apr 26, 2024
Merged

Default t_span available for DynamicsBackend.solve #353

merged 5 commits into from
Apr 26, 2024

Conversation

arthurostrauss
Copy link
Contributor

Summary

This PR introduces the possibility to use DynamicsBackend.solve()without having to specify a t_spanargument explicitly. If it is not specified, the default t_spanis inferred from the provided solve_input to create a t_spanof the form [0, solve_input.duration] for each solve_input in the provided list. This can be useful for simulating easily a full QuantumCircuits as the process of converting them to Schedule is already done behind the scenes.

Details and comments

@arthurostrauss
Copy link
Contributor Author

I'm not really sure why the tests are failing, they do not seem related to the proposed changes at all.

@DanPuzzuoli
Copy link
Collaborator

I'm not really sure why the tests are failing, they do not seem related to the proposed changes at all.

I think it may be due to the latest qutip update, which occurred after the last time the automated tests were run - I can look into it tomorrow.

@DanPuzzuoli DanPuzzuoli mentioned this pull request Apr 9, 2024
Merged
@DanPuzzuoli
Copy link
Collaborator

Okay just merged a fix for the qutip qobj handling in #354 , you can try again after updating your branch.

@arthurostrauss
backend.solve can now work without specifying t_span
ca15267 
It is now possible to infer a default t_span related to the duration of the solve inputs (in general, the user might just want to simulate the whole evolution over the circuit and not get any time step).
@arthurostrauss
Added release note and docstring
3350e8c
@arthurostrauss arthurostrauss force-pushed the default_tspan_for_backend.solve branch from 1adb67f to 3350e8c Compare April 10, 2024 01:40
@arthurostrauss
Copy link
Contributor Author

@DanPuzzuoli Any updates on this?

@DanPuzzuoli
Copy link
Collaborator

@DanPuzzuoli Any updates on this?

Hey @arthurostrauss - if this is ready for review please request my review on the right :).

@arthurostrauss arthurostrauss marked this pull request as draft April 26, 2024 08:16
@arthurostrauss arthurostrauss marked this pull request as ready for review April 26, 2024 08:16
@arthurostrauss
Copy link
Contributor Author

@DanPuzzuoli It seems I am not able to add any reviewers on the panel unfortunately (it indicates that I am not authorised to edit the PR). Can you assign yourself to the review?

@DanPuzzuoli DanPuzzuoli self-requested a review April 26, 2024 14:22
@DanPuzzuoli DanPuzzuoli merged commit 5d4f1b2 into qiskit-community:main Apr 26, 2024
16 checks passed
@arthurostrauss arthurostrauss deleted the default_tspan_for_backend.solve branch April 26, 2024 15:54
DanPuzzuoli added a commit to DanPuzzuoli/qiskit-dynamics that referenced this pull request Sep 16, 2024
@arthurostrauss @DanPuzzuoli
Add automatic determination of t_span for DynamicsBackend.solve (qi…
b919b53 
…skit-community#353)

Co-authored-by: Daniel Puzzuoli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanPuzzuoli DanPuzzuoli DanPuzzuoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthurostrauss @DanPuzzuoli