Develop to master - CKAN 2.10 compatibility #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Sep 8, 2023
ThrawnCA
commented
- Enable CKAN 2.10 testing
- Fix page components to retain basic functionality without JavaScript
- There is no need for a 'log in and do x' step when we can just invoke those two steps separately
- Invoking via the Behaving step results in an error on newer Selenium due to x and y positioning not being passed in
- Use 'translate' to ensure lowercase, as it's more future-compatible
- 'text' selects child text nodes and is rarely the right choice. 'string' provides the string representation of a node and is the correct way to select eg link text.
- /user/_logout is the correct URL. /user/logout will try to find a user named 'logout'.
- Just check the element class, not its content, since the exact content depends on timing. It could be 'Just now', or '1 second ago', or '2 seconds ago', etc.
- Separate creation of draft datasets from creation of datasets with default resources - Add persona variable so a just-created dataset can be accessed without giving it a distinctive name
- Goodtables doesn't think it's compatible with this version, but it seems to work and Frictionless (from ckanext-qa) needs it
- This also replaces an obsolete method that will not work on CKAN 2.10 due to different page elements
…g changes - This is needed to include ckanext-activity in local re-testing
…ft datasets - The interaction to create a resource for a draft dataset is slightly different from creating a new resource for an active dataset
- Use the 'press' step for more robustness, instead of 'link with text that contains' - Invoke steps rather than directly calling functions when possible
- There is a bug in Behaving that breaks this step when single quotes are used. Raised ggozad/behaving#137
- Handle dialog close button regardless of its text
… the dialog itself - Overly broad expression was matching the whole page body
- Generate fresh datasets instead of reusing one, so we don't stack up extra comments when re-running tests - Add a test for attempting to make a profane comment on a dataset
…of reusing the name
- Apply sysadmin config before creating test datasets so we have the resource formats specified - Add more data request tests - Run unit tests before scenario tests
- Enable the Report link to flag the comment even without script. It's clumsy for now, but better than nothing.
- Independently of whether we're including the staging CKAN-specific stylesheet, use the standard SWE one
…ault schema exists - Don't just hide it stylistically, there's no point in having it
…vaScript - If JavaScript is enabled, use it to reveal the fallback elements so we can test consistently
- Ensure we select the specific dataset we want
…JS better - Don't rely on the text being present or absent, examine the state of the checkbox
- Local stylesheet didn't cover the resource schema alignment fields
- No need to hide the checkbox when schemas are aligned - Combine scenario tests for matched and mismatched schemas since we're testing changing it anyway
- Checkbox behaviour has been changed, no longer hiding
- The 'subject' in the email is actually the data request title, not the comment subject. This wasn't spotted before because our test request title and our test comment subject had the same text.
- It appears that Behave doesn't fill persona placeholders if they're only part of the argument
- Convert link to a button that will POST to the API if not intercepted by JavaScript. This is not an ideal solution, since it will result in a JSON response, but it will work instead of getting 404 Not Found.
- The tag should cover what we want to test, no other constraint is desirable
- Ensure that after making schemas align, we can change the resource schema again - Ensure that we can align the schemas by checking the box, rather than manually
QOLDEV-312 add testing for CKAN 2.10
ThrawnCA
requested review from
duttonw,
kundupz,
chris-randall-qol and
RossWebsterWork
duttonw
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.