[QOLDEV-1011] ensure we only fall back to 'c' if parameters are undef… #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ined (not just falsy)
duttonw
reviewed
Dec 5, 2024
| {% set datarequest = datarequest or c.datarequest %} | ||
| {% set errors = errors or c.errors %} | ||
| {% set errors_summary = errors_summary or c.errors_summary %} | ||
| {% if datarequest is not defined %} |
There was a problem hiding this comment.
why is datarequest the controller of this?
There was a problem hiding this comment.
It's a good indicator of whether we're running a version of ckanext-datarequests that relies on c or uses extra_vars. The other option would be to individually test for the presence of each parameter, but that seems unnecessary when this is a temporary shim.
duttonw
approved these changes
Dec 5, 2024
ThrawnCA
force-pushed
the
QOLDEV-1011-datarequests-ckan-2.11
branch
from
183c300 to
775ca00
Compare
duttonw
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ined (not just falsy)