QOLSVC-8587 fix non-truncated titles #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Truncate long labels even if a custom label function is in use
|
Raised ckan/ckan#8585 to address this upstream. |
duttonw
reviewed
Dec 16, 2024
| {% set label = label_function(name, item) if label_function else item.display_name %} | ||
| {% set label_truncated = label|truncate(22) if not label_function else label %} | ||
| {% set label_truncated = label|truncate(22) %} |
There was a problem hiding this comment.
did we have to 'hack' the side bar to split the data sources??
has ckan 2.10 or 2.11 made this easier to not need to do the split?
also what exactly are we needing to add/update/remove when compared to ckan core or our theme?
There was a problem hiding this comment.
From
dataset and geoscience) into domain names (data.qld.gov.au and geoscience.data.qld.gov.au).
duttonw
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a custom label function caused long titles not to be truncated.
It isn't worth trying to recreate Jinja truncation within our helper function, so just apply it regardless of the custom function's presence.