[QOLDEV-933] drop redirection of private datasets #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThrawnCA
commented
Sep 24, 2024
ThrawnCA
commented
- This is now a core feature, we don't need it in the plugin. We also need to adjust its behaviour to optionally give 404 on deleted datasets for PURL.
- This is now a core feature, we don't need it in the plugin. We also need to adjust its behaviour to optionally give 404 on deleted datasets for PURL.
Do you mean tests here, or tests in core? Not sure how best to test a dropped feature. |
both |
We have tests for the login redirection both here and in infrastructure. They initially failed when the plugin feature was removed here, but are working with the core feature enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.