Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix example code in quantum_painter.md #24897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricBanker12
Copy link

[Docs] Fix example code in quantum_painter.md

Fixes #24896

Description

Fixes example code that would unintentionally display an image 1 pixel up-left of the intended bottom-right corner position. Additionally, fixes edge case causing uint16_t overflow for images the same size as the display.

See #24896 for more details.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@EricBanker12 EricBanker12 marked this pull request as ready for review February 3, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Quantum Painter Draw Image Example Code Is Wrong And Causes uint16_t Overflow
2 participants