Fix issue where truncated job names would cause the job to fail. #45
Conversation
Fixes an issue where workflow names would be truncated and cause the action to fail. Root cause: When the line length of the job name + matrix inputs exceeds 97 characters in GHA. The name is truncated and an ellipsis is appended. This caused the action to fail. Fix: Truncate the name just like GHA does. Signed-off-by: Collin Charvat <[email protected]>
Fix GHA matrix length issue Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
…ons--context Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
This reverts commit dd6d641.
…vat/actions--context" This reverts commit 2f63e34, reversing changes made to e9228cb.
* Create example-reusable-from-matrix.yml * Update example.yaml * Update actions.ts * Update index.js * build Signed-off-by: Collin Charvat <[email protected]> * fix_missing_input Signed-off-by: Collin Charvat <[email protected]> * add_max_parallel_test Signed-off-by: Collin Charvat <[email protected]> --------- Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
|
@qoomon Please ignore my horrible commit history. If i move the tests into example.yml, things start to break down and that was what i was looking into before i saw you had already replied. |
qoomon
force-pushed
the
main
branch
2 times, most recently
from
188aa81
to
565de6b
Compare
|
Unfortunately I'll be offline until end of October, I'll get back to this issue then |
|
Instead of find function we should use filter function instead check if matching jobs has a length of exactly 1 |
|
I'll implement that and leave it here for you when you get back! |
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
|
Please squash your commits |
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
Signed-off-by: Collin Charvat <[email protected]>
|
@qoomon Now that your back, Ive discovered another issue, it appears that the cut off inst exactly 97? Edit: The cut off is 100, and if it exceeds its truncated down. I added tests, for it. However, actions/runner#3489 is the best and only way to really fix this issue. Im trying to reach out to Enterprise contacts, through my work to get them to review. |
|
Reason for closing? I still think these are good changes (at least bring over the 100 character fix)? |
|
Sorry misunderstood your |
|
Sorry i should have said: "Is the Correct solution to this in the long term" These changes are still good in the short term. |
Fix the issue where truncated job names would cause the job to fail.
Root Cause: When the job name + matrix inputs exceeds 97 characters GHA truncates the job name and appends an ellipsis.
This would cause the match to fail, since the action would build out the absolute path.
Potential issues:
This opens the door to non unique job names (because the "uniqueness" is in what is truncated).
My solution for this was to use the runner name as a second id when filtering.
It was the only other piece of into i could find shared between "workflowRunJobs" and the github context.