formatting tweaks

qooxdoo · Jan 10, 2024 · aa5a1b7 · aa5a1b7
1 parent 318086f
commit aa5a1b7
Show file tree

Hide file tree

Showing 20 changed files with 257 additions and 269 deletions.
diff --git a/source/class/qxl/datagrid/DataGrid.js b/source/class/qxl/datagrid/DataGrid.js
@@ -423,7 +423,7 @@ qx.Class.define("qxl.datagrid.DataGrid", {
      * @param {Integer} pos
      */
     scrollToX(pos) {
-      // TODO
+      /* TODO */
     },
 
     /**
@@ -432,7 +432,7 @@ qx.Class.define("qxl.datagrid.DataGrid", {
      * @param {Integer} pos
      */
     scrollToY(pos) {
-      //TODO
+      /* TODO */
     },
 
     /**
@@ -446,7 +446,6 @@ qx.Class.define("qxl.datagrid.DataGrid", {
       }
 
       let size = this.getDataSource().getSize();
-
       let scrollbarX = this.getChildControl("scrollbar-x");
       let columns = this.getColumns();
       let showX = this.getScrollbarX();
@@ -518,7 +517,9 @@ qx.Class.define("qxl.datagrid.DataGrid", {
 
           control.exclude();
           control.addListener("scroll", e => {
-            if (this.__inApplyStartRowIndex) return;
+            if (this.__inApplyStartRowIndex) {
+              return;
+            }
             let position = e.getData();
             let rowCount = this.getDataSource().getSize().getRow();
             const startRowIndex = Math.floor(qxl.datagrid.util.Math.interpolate(0, 100, 0, Math.max(0, rowCount - this.getMaxRows()), position));
@@ -538,10 +539,6 @@ qx.Class.define("qxl.datagrid.DataGrid", {
       return super._createChildControlImpl(id);
     },
 
-    /**
-     * @Override
-     *    
-
     /**
      * Updates the display after changes to data or columns etc
      */

diff --git a/source/class/qxl/datagrid/column/Columns.js b/source/class/qxl/datagrid/column/Columns.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 /**
  * Provides a simple list of columns

diff --git a/source/class/qxl/datagrid/column/FilteredColumns.js b/source/class/qxl/datagrid/column/FilteredColumns.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 /**
  * Wraps another instance of IColumns to filter and sort the list; this allows the user interface

diff --git a/source/class/qxl/datagrid/column/IColumns.js b/source/class/qxl/datagrid/column/IColumns.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 /**
  * Implemented by objects that can provide a list of columns for the datagrid.

diff --git a/source/class/qxl/datagrid/column/tree/IExpansionWidget.js b/source/class/qxl/datagrid/column/tree/IExpansionWidget.js
@@ -20,7 +20,7 @@
  *
  * *********************************************************************** */
 
-qx.Interface.define( "qxl.datagrid.column.tree.IExpansionWidget", {
+qx.Interface.define("qxl.datagrid.column.tree.IExpansionWidget", {
   properties: {
     /** How deep the indentation level is */
     indentationLevel: {

diff --git a/source/class/qxl/datagrid/demo/array/DummyModel.js b/source/class/qxl/datagrid/demo/array/DummyModel.js
@@ -94,8 +94,9 @@ qx.Class.define("qxl.datagrid.demo.array.DummyModel", {
         "Hawk",
         "Falcon",
         "Vulture",
-        "Penguin",
+        "Penguin"
       ];
+
       return nouns[Math.floor(Math.random() * nouns.length)];
     },
 

diff --git a/source/class/qxl/datagrid/demo/theme/tangible/Appearance.js b/source/class/qxl/datagrid/demo/theme/tangible/Appearance.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 qx.Theme.define("qxl.datagrid.demo.theme.tangible.Appearance", {
   extend: qx.theme.tangible.Appearance,

diff --git a/source/class/qxl/datagrid/demo/theme/tangible/Decoration.js b/source/class/qxl/datagrid/demo/theme/tangible/Decoration.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 qx.Theme.define("qxl.datagrid.demo.theme.tangible.Decoration", {
   extend: qx.theme.tangible.Decoration,

diff --git a/source/class/qxl/datagrid/demo/theme/tangible/Theme.js b/source/class/qxl/datagrid/demo/theme/tangible/Theme.js
@@ -1,25 +1,25 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
-qx.Theme.define( "qxl.datagrid.demo.theme.tangible.Theme", {
+qx.Theme.define("qxl.datagrid.demo.theme.tangible.Theme", {
   meta: {
     color: qxl.datagrid.demo.theme.tangible.Color,
     decoration: qxl.datagrid.demo.theme.tangible.Decoration,

diff --git a/source/class/qxl/datagrid/demo/tree/TreeDemoNodeInspector.js b/source/class/qxl/datagrid/demo/tree/TreeDemoNodeInspector.js
@@ -1,23 +1,23 @@
 /* ************************************************************************
-*
-*    Qooxdoo DataGrid
-*
-*    https://github.com/qooxdoo/qooxdoo
-*
-*    Copyright:
-*      2022-23 Zenesis Limited, https://www.zenesis.com
-*
-*    License:
-*      MIT: https://opensource.org/licenses/MIT
-*
-*      This software is provided under the same licensing terms as Qooxdoo,
-*      please see the LICENSE file in the Qooxdoo project's top-level directory
-*      for details.
-*
-*    Authors:
-*      * John Spackman ([email protected], @johnspackman)
-*
-* *********************************************************************** */
+ *
+ *    Qooxdoo DataGrid
+ *
+ *    https://github.com/qooxdoo/qooxdoo
+ *
+ *    Copyright:
+ *      2022-23 Zenesis Limited, https://www.zenesis.com
+ *
+ *    License:
+ *      MIT: https://opensource.org/licenses/MIT
+ *
+ *      This software is provided under the same licensing terms as Qooxdoo,
+ *      please see the LICENSE file in the Qooxdoo project's top-level directory
+ *      for details.
+ *
+ *    Authors:
+ *      * John Spackman ([email protected], @johnspackman)
+ *
+ * *********************************************************************** */
 
 qx.Class.define("qxl.datagrid.demo.tree.TreeDemoNodeInspector", {
   extend: qxl.datagrid.source.tree.NodeInspector,

diff --git a/source/class/qxl/datagrid/source/AbstractDataSource.js b/source/class/qxl/datagrid/source/AbstractDataSource.js
@@ -69,7 +69,9 @@ qx.Class.define("qxl.datagrid.source.AbstractDataSource", {
      */
     _parseDataKey(str) {
       let pos = 5;
-      if (str.length !== 11) pos = str.indexOf(":");
+      if (str.length !== 11) {
+        pos = str.indexOf(":");
+      }
       let row = parseInt(str.substring(0, pos), 10);
       let column = parseInt(str.substring(pos + 1), 10);
       return { row, column };

diff --git a/source/class/qxl/datagrid/source/Range.js b/source/class/qxl/datagrid/source/Range.js
@@ -275,7 +275,7 @@ qx.Class.define("qxl.datagrid.source.Range", {
      */
     __applyXxxx(value) {
       if (value) {
-        value.addListener("change", evt => this.fireEvent("change"), this);
+        value.addListener("change", evt => this.fireEvent("change"));
       }
     }
   },