Kit: Only use Kits generated by cmake extension as templates

Since our Kits are mixed in with the cmake-extension generated kits
we need to filter them out so we don't use them as templates.

Without this patch the kit-generator would try to create new Qt Kits
using the previously created kits as templates.

Change-Id: If945b5edfa7eba9a9ea08282f238d91e7744f691
Reviewed-by: Marcus Tillmanns <[email protected]>

src/kit-manager.ts

@@ -468,16 +468,24 @@ export class KitManager {
     qtFolder: string,
     qtInstallations: string[]
   ) {
-    const loadedCMakeKits = await KitManager.loadCMakeKitsFileJSON();
+    const allCMakeKits = await KitManager.loadCMakeKitsFileJSON();
     logger.info(`qtFolder: "${qtFolder}"`);
-    logger.info(`Loaded CMake kits: ${JSON.stringify(loadedCMakeKits)}`);
+    logger.info(`Loaded CMake kits: ${JSON.stringify(allCMakeKits)}`);
+    // Filter out kits generated by us, since we only want to use Kits
+    // that were created by the cmake extension as templates.
+    const kitsFromCMakeExtension = allCMakeKits.filter(
+      (kit) => kit.environmentVariables?.VSCODE_QT_FOLDER === undefined
+    );
+    logger.info(
+      `Kits from CMake extension: ${JSON.stringify(kitsFromCMakeExtension)}`
+    );
     logger.info(`Qt installations: ${JSON.stringify(qtInstallations)}`);
     const kits = [];
     for (const installation of qtInstallations)
       for await (const kit of KitManager.generateCMakeKitsOfQtInstallationPath(
         qtFolder,
         installation,
-        loadedCMakeKits
+        kitsFromCMakeExtension
       ))
         kits.push(kit);
     return kits;