-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grand master split #6
Open
VoR0220
wants to merge
20
commits into
qtumproject:proto-x86
Choose a base branch
from
VoR0220:grandMasterSplit
base: proto-x86
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: VoR0220 <[email protected]>
added new simpleABI into the fold
…e more change Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
…t of toolchain, delete old docker Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Signed-off-by: VoR0220 <[email protected]>
Earlz
reviewed
Jul 2, 2019
function qx86make() { | ||
docker run --rm -v "${PWD}:/root/bind" qtumx86 qmake "$@" | ||
docker run --rm -v "${PWD}:/root/bind" -w "/root/bind" qtumtoolchain-alpine make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ""$@"" is needed so that qx86make clean
for example works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VoR0220 Hi, once this is resolved, I am able to merge the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits apart the qtum client and the qtum toolchain for x86 development, making our infrastructure more modular and easier to maintain and our containers SIGNIFICANTLY smaller.
Qtum client is sitting at ~47MB
Qtum toolchain is sitting at ~1.7GB
This is down from a grand total of ~8.6GB.