testing image inclusion in reports #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderwin
force-pushed
the
feature/images-in-reports
branch
from
b43ae22 to
e777077
Compare
Closed
nderwin
force-pushed
the
feature/images-in-reports
branch
4 times, most recently
from
d353346 to
58aa15d
Compare
* set up a report that includes images from inside the application, from the static resources of the application, and from an external source * added a unit test to validate that the HTML export includes `img` tags with not-empty `src` attributes * added endpoints for PDF and XLSX output * added an application-wide HTML file resource handler to deal with storing the images in a temp folder * setup and tear down the temp folder and any files in it with the application lifecycle * added a REST endpoint to serve images from the temp directory for HTML reports Signed-off-by:Nathan Erwin <[email protected]>
nderwin
force-pushed
the
feature/images-in-reports
branch
from
58aa15d to
1c4af40
Compare
nderwin
changed the title
|
@melloware marking this up as ready for review, but the native build is failing because... I didn't do something, but not sure what. |
melloware
approved these changes
Oct 18, 2024
|
Working on fixing the native image now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imgtags with not-emptysrcattributesSigned-off-by:Nathan Erwin [email protected]