Move the configuration to @ConfigMapping #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy config classes will go away at some point in the future so let's migrate to @ConfigMapping.
gsmet
commented
Feb 12, 2025
| @@ -207,7 +206,6 @@ void generateSqlSessionFactory(MyBatisRuntimeConfig myBatisRuntimeConfig, | |||
| configurationCustomizers, | |||
| sqlSessionFactoryBuilderBuildItem.getBuilder(), | |||
| myBatisRuntimeConfig, | |||
| dataSourceConfig, | |||
There was a problem hiding this comment.
You actually cannot pass partial config objects to recorder. So here I will extract MyBatisDataSourceRuntimeConfig in the recorder instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy config classes will go away at some point in the future so let's migrate to @ConfigMapping.