Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Quarkus platform PR info to the project.yml file #1026

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xstefank
Copy link
Member

Fixes #996

@xstefank xstefank requested a review from metacosm January 20, 2025 07:18
@xstefank xstefank requested a review from a team as a code owner January 20, 2025 07:18
@xstefank
Copy link
Member Author

@metacosm design is open for discussion. Metadata extension only takes the leaf name of the yaml, so any structure in project.yml is ignored.

Copy link
Member

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There needs to be potentially several target branches as a platform PR might need to be opened against main but also the current stable version (for example, right now, main and 3.17 potentially)


quarkus-platform:
target-branch: main
needs-main-pr: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this shouldn't be needed anymore if we specify branches to target explicitly

@metacosm
Copy link
Member

@metacosm design is open for discussion. Metadata extension only takes the leaf name of the yaml, so any structure in project.yml is ignored.

Ah, too bad. In that case, the leaf should probably contain quarkus-platform in some form in its name to avoid potential collisions?

@xstefank xstefank force-pushed the quarkus-platform-pr-info-project-yml-996 branch from 915fe22 to 3533881 Compare January 21, 2025 16:15
@xstefank xstefank requested a review from metacosm January 21, 2025 16:15
@xstefank xstefank force-pushed the quarkus-platform-pr-info-project-yml-996 branch from 3533881 to 74d88c6 Compare January 21, 2025 16:16

quarkus-platform-branches:
- "main"
- "3.17"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@metacosm these don't need to be strings, but otherwise we will get warnings that we mix strings and numbers. I mean, it can also be without quotes like this if preferred:

  quarkus-platform-branches:
    - main
    - 3.17

@xstefank xstefank force-pushed the quarkus-platform-pr-info-project-yml-996 branch from 74d88c6 to 3b9f9b4 Compare January 22, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Quarkiverse platform update process on release
2 participants