-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move Quarkus platform PR info to the project.yml file #1026
base: main
Are you sure you want to change the base?
chore: move Quarkus platform PR info to the project.yml file #1026
Conversation
@metacosm design is open for discussion. Metadata extension only takes the leaf name of the yaml, so any structure in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be potentially several target branches as a platform PR might need to be opened against main
but also the current stable version (for example, right now, main
and 3.17
potentially)
.github/project.yml
Outdated
|
||
quarkus-platform: | ||
target-branch: main | ||
needs-main-pr: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this shouldn't be needed anymore if we specify branches to target explicitly
Ah, too bad. In that case, the leaf should probably contain |
915fe22
to
3533881
Compare
3533881
to
74d88c6
Compare
|
||
quarkus-platform-branches: | ||
- "main" | ||
- "3.17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metacosm these don't need to be strings, but otherwise we will get warnings that we mix strings and numbers. I mean, it can also be without quotes like this if preferred:
quarkus-platform-branches:
- main
- 3.17
Signed-off-by: xstefank <[email protected]>
74d88c6
to
3b9f9b4
Compare
Fixes #996