Use recommended stream instead of alpha in code.quarkus links #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holly-cummins
force-pushed
the
use-recommended-stream-instead-of-alpha
branch
from
3e6780e to
0cf9da5
Compare
|
🙈 The PR is closed and the preview is expired. |
maxandersen
reviewed
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161. We assume most platform extensions we list were in the last recommended stream of the platform, and so we omit the platform when creating code.quarkus links. This means we don't push people onto creating alphas.
Example good case:
https://extensions-quarkus-pr-177-preview.surge.sh/io.quarkus/quarkus-agroal gives a link https://code.quarkus.io/?e=agroal
The downside is for some extensions, the code.quarkus.io links no longer work correctly. Example bad case:
https://extensions-quarkus-pr-177-preview.surge.sh/io.quarkus/quarkus-azure-functions
