Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Maven/Wrapper/Develocity Versions for better Compatibility #49

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

lasteris
Copy link
Contributor

These changes solves quarkusio/quarkus#42756.

What i have done to check ?

  1. Made commit changes.
  2. ./mvnw clean install (quarkus-project-develocity-extension, 1.1.6-SNAPSHOT to make it visible via local m2) 3) Made some changes to https://github.com/quarkusio/quarkus/blob/main/.mvn/extensions.xml, which is now looking as below:
 <extensions>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>develocity-maven-extension</artifactId>
        <version>1.22.2</version>
    </extension>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>common-custom-user-data-maven-extension</artifactId>
        <version>2.0.1</version>
    </extension>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>quarkus-build-caching-extension</artifactId>
        <version>1.8</version>
    </extension>
    <extension>
        <groupId>io.quarkus.develocity</groupId>
        <artifactId>quarkus-project-develocity-extension</artifactId>
        <version>1.1.6-SNAPSHOT</version>
    </extension>
</extensions>
  1. cd into quarkus project git repository root directory on my disk drive 5) ./mvnw -Dquickly

Result looks like that:

...

[INFO] Quarkus - Documentation ............................ SUCCESS [ 10.929 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  35:00 min
[INFO] Finished at: 2024-10-09T17:33:10+03:00
[INFO] ------------------------------------------------------------------------
[INFO] 14725 goals, 14709 executed, 16 from cache

This is only way how i finally successfully built Quarkus on my Windows machine via Maven Wrapper or even locally installed Maven of version 3.9.9

These changes solves quarkusio/quarkus#42756.

What i have done to check ?

1) Made commit changes.
2) ./mvnw clean install (quarkus-project-develocity-extension, 1.1.6-SNAPSHOT to make it visible via local m2)
3) Made some changes to https://github.com/quarkusio/quarkus/blob/main/.mvn/extensions.xml, which is now looking as below:

```
 <extensions>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>develocity-maven-extension</artifactId>
        <version>1.22.2</version>
    </extension>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>common-custom-user-data-maven-extension</artifactId>
        <version>2.0.1</version>
    </extension>
    <extension>
        <groupId>com.gradle</groupId>
        <artifactId>quarkus-build-caching-extension</artifactId>
        <version>1.8</version>
    </extension>
    <extension>
        <groupId>io.quarkus.develocity</groupId>
        <artifactId>quarkus-project-develocity-extension</artifactId>
        <version>1.1.6-SNAPSHOT</version>
    </extension>
</extensions>
```
4) cd into quarkus project git repository root directory on my disk drive
5) ./mvnw -Dquickly

Result looks like that:

```
...

[INFO] Quarkus - Documentation ............................ SUCCESS [ 10.929 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  35:00 min
[INFO] Finished at: 2024-10-09T17:33:10+03:00
[INFO] ------------------------------------------------------------------------
[INFO] 14725 goals, 14709 executed, 16 from cache
```

This is only way how i finally successfully built Quarkus on my Windows machine via Maven Wrapper or even locally installed Maven of version 3.9.9
@gsmet
Copy link
Member

gsmet commented Oct 10, 2024

Thanks. Not sure what's going on as I would have expected Maven to enforce the versions but if it works for you, let's merge it.

Thanks for digging and providing the fix!

@gsmet gsmet merged commit e938b51 into quarkusio:main Oct 10, 2024
1 check passed
@gsmet
Copy link
Member

gsmet commented Oct 10, 2024

I released a new version. Dependabot should take care of the update tonight.

@lasteris
Copy link
Contributor Author

Thanks. Not sure what's going on as I would have expected Maven to enforce the versions but if it works for you, let's merge it.

Thanks for digging and providing the fix!

I think the main job is done via Develocity version update😉

@jprinet
Copy link
Contributor

jprinet commented Oct 10, 2024

Could you actually run the build twice @lasteris and check that a build cache hit happens instead of the previous error?

@lasteris
Copy link
Contributor Author

lasteris commented Oct 10, 2024

Could you actually run the build twice @lasteris and check that a build cache hit happens instead of the previous error?

I can clean and build twice sequentially. Wait me 🌚

@lasteris
Copy link
Contributor Author

@jprinet

[INFO] -----------< io.quarkus:quarkus-kubernetes-service-binding >------------
[INFO] Building Quarkus - Kubernetes Service Binding - Runtime 999-SNAPSHOT [221/1230]
[INFO]   from extensions\kubernetes-service-binding\runtime\pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- clean:3.2.0:clean (clean-cache-dirs) @ quarkus-kubernetes-service-binding ---
[INFO] Deleting C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\target
[INFO] Deleting C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\.cache (includes = [], excludes = [])
[INFO]
[INFO] --- clean:3.2.0:clean (default-clean) @ quarkus-kubernetes-service-binding ---
[INFO] 
[INFO] --- buildnumber:3.0.0:create (get-scm-revision) @ quarkus-kubernetes-service-binding ---
[INFO]
[INFO] --- formatter:2.24.1:format (default) @ quarkus-kubernetes-service-binding ---
[INFO] Loaded from the build cache
[INFO]
[INFO] --- impsort:1.12.0:sort (sort-imports) @ quarkus-kubernetes-service-binding ---
[INFO] Loaded from the build cache, saving 0.004s
[INFO]
[INFO] --- resources:3.3.1:resources (default-resources) @ quarkus-kubernetes-service-binding ---
[INFO] Copying 1 resource from src\main\resources to target\classes
[INFO]
[INFO] --- quarkus-extension:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) @ quarkus-kubernetes-service-binding ---
[INFO] 
[INFO] --- compiler:3.13.0:compile (default-compile) @ quarkus-kubernetes-service-binding ---
[INFO] Loaded from the build cache, saving 0.413s
[INFO]
[INFO] --- resources:3.3.1:testResources (default-testResources) @ quarkus-kubernetes-service-binding ---
[INFO] Copying 11 resources from src\test\resources to target\test-classes
[INFO]
[INFO] --- compiler:3.13.0:testCompile (default-testCompile) @ quarkus-kubernetes-service-binding ---
[INFO] Loaded from the build cache, saving 0.133s
[INFO]
[INFO] --- surefire:3.5.0:test (default-test) @ quarkus-kubernetes-service-binding ---
[INFO] Skipped
[INFO]
[INFO] --- jar:3.3.0:jar (default-jar) @ quarkus-kubernetes-service-binding ---
[INFO] Building jar: C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\target\quarkus-kubernetes-service-binding-999-SNAPSHOT.jar
[INFO]
[INFO] --- source:3.2.1:jar-no-fork (attach-sources) @ quarkus-kubernetes-service-binding ---
[INFO] Building jar: C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\target\quarkus-kubernetes-service-binding-999-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- install:3.1.1:install (default-install) @ quarkus-kubernetes-service-binding ---
[INFO] Installing C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\pom.xml to C:\Users\asus\.m2\repository\io\quarkus\quarkus-kubernetes-service-binding\999-SNAPSHOT\quarkus-kubernetes-service-binding-999-SNAPSHOT.pom
[INFO] Installing C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\target\quarkus-kubernetes-service-binding-999-SNAPSHOT.jar to C:\Users\asus\.m2\repository\io\quarkus\quarkus-kubernetes-service-binding\999-SNAPSHOT\quarkus-kubernetes-service-binding-999-SNAPSHOT.jar
[INFO] Installing C:\Users\asus\repo\quarkus\extensions\kubernetes-service-binding\runtime\target\quarkus-kubernetes-service-binding-999-SNAPSHOT-sources.jar to C:\Users\asus\.m2\repository\io\quarkus\quarkus-kubernetes-service-binding\999-SNAPSHOT\quarkus-kubernetes-service-binding-999-SNAPSHOT-sources.jar

.....

[INFO] Quarkus - Kubernetes Service Binding - Deployment .. SUCCESS [  0.584 s]

....

[INFO] Quarkus - Kubernetes Service Binding - SPI ......... SUCCESS [  0.358 s]

result output per second build for problematic extension

@jprinet
Copy link
Contributor

jprinet commented Oct 10, 2024

Great @lasteris and thanks for reporting back, looks like the local cache hit does not break the build, I am still expecting a full confirmation with a remote cache hit when the Quarkus build will have run with the upgraded extension.

@lasteris
Copy link
Contributor Author

lasteris commented Oct 10, 2024

I am still expecting a full confirmation with a remote cache hit when the Quarkus build will have run with the upgraded extension.

For remote cache, I need an account to Develocity ?

@jprinet
Copy link
Contributor

jprinet commented Oct 10, 2024

The remote cache will be populated by the CI workflow.
You will then be able to get remote cache hit.
See this for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants