-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Maven/Wrapper/Develocity Versions for better Compatibility #49
Conversation
These changes solves quarkusio/quarkus#42756. What i have done to check ? 1) Made commit changes. 2) ./mvnw clean install (quarkus-project-develocity-extension, 1.1.6-SNAPSHOT to make it visible via local m2) 3) Made some changes to https://github.com/quarkusio/quarkus/blob/main/.mvn/extensions.xml, which is now looking as below: ``` <extensions> <extension> <groupId>com.gradle</groupId> <artifactId>develocity-maven-extension</artifactId> <version>1.22.2</version> </extension> <extension> <groupId>com.gradle</groupId> <artifactId>common-custom-user-data-maven-extension</artifactId> <version>2.0.1</version> </extension> <extension> <groupId>com.gradle</groupId> <artifactId>quarkus-build-caching-extension</artifactId> <version>1.8</version> </extension> <extension> <groupId>io.quarkus.develocity</groupId> <artifactId>quarkus-project-develocity-extension</artifactId> <version>1.1.6-SNAPSHOT</version> </extension> </extensions> ``` 4) cd into quarkus project git repository root directory on my disk drive 5) ./mvnw -Dquickly Result looks like that: ``` ... [INFO] Quarkus - Documentation ............................ SUCCESS [ 10.929 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 35:00 min [INFO] Finished at: 2024-10-09T17:33:10+03:00 [INFO] ------------------------------------------------------------------------ [INFO] 14725 goals, 14709 executed, 16 from cache ``` This is only way how i finally successfully built Quarkus on my Windows machine via Maven Wrapper or even locally installed Maven of version 3.9.9
Thanks. Not sure what's going on as I would have expected Maven to enforce the versions but if it works for you, let's merge it. Thanks for digging and providing the fix! |
I released a new version. Dependabot should take care of the update tonight. |
I think the main job is done via Develocity version update😉 |
Could you actually run the build twice @lasteris and check that a build cache hit happens instead of the previous error? |
I can clean and build twice sequentially. Wait me 🌚 |
result output per second build for problematic extension |
Great @lasteris and thanks for reporting back, looks like the local cache hit does not break the build, I am still expecting a full confirmation with a remote cache hit when the Quarkus build will have run with the upgraded extension. |
For remote cache, I need an account to Develocity ? |
The remote cache will be populated by the CI workflow. |
These changes solves quarkusio/quarkus#42756.
What i have done to check ?
Result looks like that:
This is only way how i finally successfully built Quarkus on my Windows machine via Maven Wrapper or even locally installed Maven of version 3.9.9