Add a recipe to rewrite @QuarkusTestResource to @WithTestResource #187
Conversation
|
It looks ok to me. The only question I'd have is what if other attributes were set on |
|
Yes, I don't think they would be changed. But I can add a test for it. |
|
Done! |
|
|
||
| import io.quarkus.test.common.WithTestResource; | ||
|
|
||
| @WithTestResource(restrictToAnnotatedClass = true) |
There was a problem hiding this comment.
In this case where @QuarkusTestResource(restrictToAnnotatedClass = true), it would be nicer I think if we just eliminated the attribute, since the default in @WithTestResource is true.
I'm not sure if thats possible though. I don't know much about Open Rewrite.
There was a problem hiding this comment.
We probably could but I thought about it when doing it and I decided it was not worth the hassle, given the size of my TODO list :).
There was a problem hiding this comment.
Yeah I think it was one of those "this would be nice if it was easy to do" things.
@edeandrea could you check the tests make sense? I set the default value to keep the behavior people were getting with the deprecated annotation.