Merge pull request #32035 from holly-cummins/fix-test-dependency

Remove unwanted (and unnecessary) build-order dependency from test
quarkusio · Mar 22, 2023 · f7c1102 · f7c1102
2 parents e1d1a87 + d293da8
commit f7c1102
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/...-maven-plugin/src/test/resources/fake-extension-runtime-with-missing-dependencies/pom.xml b/...-maven-plugin/src/test/resources/fake-extension-runtime-with-missing-dependencies/pom.xml
@@ -17,7 +17,9 @@
     <dependency>
       <groupId>io.quarkus</groupId>
       <artifactId>quarkus-core</artifactId>
-      <version>${project.version}</version>
+      <!-- The version in this dependency is arbitrary, but needs to be 'real' (downloadable from maven).
+      It should not be a snapshot build, to avoid introducing a build-order dependency into this test. -->
+      <version>2.12.0.Final</version>
     </dependency>
 
     <!-- Mirror of the deployment artifact's dependencies would be here, but is deliberately missing -->

diff --git a/...pendent-projects/extension-maven-plugin/src/test/resources/fake-extension-runtime/pom.xml b/...pendent-projects/extension-maven-plugin/src/test/resources/fake-extension-runtime/pom.xml
@@ -19,7 +19,7 @@
   </properties>
 
   <!-- The versions in these dependencies are arbitrary, but need to match
-  in the runtime and deployment poms. -->
+  in the runtime and deployment poms. They should not be a snapshot build, to avoid introducing a build-order dependency into this test. -->
   <dependencies>
     <dependency>
       <groupId>io.quarkus</groupId>