Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore config_ordinal for default values source #15257

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Ignore config_ordinal for default values source #15257

merged 1 commit into from
Feb 23, 2021

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Feb 22, 2021 •
edited by geoand
Loading

Fixes #15221

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/config area/core labels Feb 22, 2021
@geoand geoand merged commit 3fdebef into quarkusio:master Feb 23, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 23, 2021
@geoand
Copy link
Contributor

geoand commented Feb 23, 2021

@radcortez I assume we should backport to 1.11 and 1.12, right?

@radcortez
Copy link
Member Author

1.12 for sure. Are we still releasing 1.11.x?

@geoand
Copy link
Contributor

geoand commented Feb 23, 2021

Only if necesary :)

@radcortez
Copy link
Member Author

Ok. 1.12 should be enough.

@geoand
Copy link
Contributor

geoand commented Feb 23, 2021

I added the label for both as it is a very small change and we can see if it's needed

@gsmet gsmet modified the milestones: 1.13 - master, 1.12.1.Final Feb 24, 2021
@gsmet gsmet modified the milestones: 1.12.1.Final, 1.11.4.Final Feb 24, 2021
@radcortez radcortez deleted the fix-15221 branch March 22, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/config area/core
Projects
None yet
Milestone
1.11.4.Final
Development

Successfully merging this pull request may close these issues.

config_ordinal defined as property leaks into default properties
3 participants
@radcortez @geoand @gsmet