-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update filename of security policy content #32043
Conversation
I've made an omission. |
@gsmet Right now, if I search for |
In this PR ( Now the two files match in this respect. |
After these two PRs are merged and Google re-indexes the site, I believe search results will change as follows:
|
fa50284
to
5383a4c
Compare
@gsmet Please review and merge. |
5383a4c
to
bb103a9
Compare
Sounds good, it will become clearer IMHO, let me approve, but I'd like Guillaume to double check |
@rolfedh If I press the |
c9000cd
to
c555c66
Compare
@rolfedh So, just to confirm, does the link which can be found in https://github.com/quarkusio/quarkus/issues/new/choose will work after the file is renamed ? |
c555c66
to
d4bb765
Compare
Ah, I see what you mean now. That link is controlled somewhere outside the contents of the repo: Perhaps in the repo settings? |
d4bb765
to
2f40822
Compare
@sberyozkin I'll create an issue requesting this update if/when we decide to merge this PR. |
I'm guessing it might be a description field in GitHub the issue templates: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository |
b2044c0
to
e71b704
Compare
@sberyozkin @gsmet |
/assign @gsmet |
e71b704
to
b5730cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not something we can tweak. See https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository .
The SECURITY.md
file needs to stay and let's not duplicate it.
Based on this new information, I'll close this PR. |
Thanks @gsmet, @rolfedh What do you think though about updating not the file name itself but the title of the page, from |
The PR #1665 fixes Issue #1664 by making the following improvements:
|
References issue: quarkusio/quarkusio.github.io#1664
Also see pull-request: quarkusio/quarkusio.github.io#1665