Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filename of security policy content #32043

Closed
wants to merge 1 commit into from

Conversation

rolfedh
Copy link
Contributor

@rolfedh rolfedh commented Mar 22, 2023

@sberyozkin
Copy link
Member

Thanks @rolfedh I wonder though should we also change the title of that document from Security to Security Policy and the link from /security to security-policy ?
@gsmet Guillaume, would you agree ?

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 22, 2023

I've made an omission.
The canonical file for this content is in a different repo: https://github.com/quarkusio/quarkusio.github.io/blob/develop/security.adoc
I'll create a separate PR to make a parallel set of changes there, too.

@sberyozkin
Copy link
Member

@gsmet Right now, if I search for Quarkus Security the 1st and 5th hits will offer what looks like the same information, while in fact the 5th hit points to Quarkus Security Policy which is why I've asked the Doc team to help with making it clearer

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 22, 2023

the title of that document from Security to Security Policy

In this PR (quarkusio), the title was already "Security policy" before I renamed the file.
In the other PR for quarkusio.github.io, I updated the title to "Security policy".

Now the two files match in this respect.

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 22, 2023

@gsmet Right now, if I search for Quarkus Security the 1st and 5th hits will offer what looks like the same information, while in fact the 5th hit points to Quarkus Security Policy which is why I've asked the Doc team to help with making it clearer

After these two PRs are merged and Google re-indexes the site, I believe search results will change as follows:

  • The "Quarkus Security overview" link (SERP 1) will remain unchanged.
  • The "Security - Quarkus" link (SERP 5) will change to "Security policy - Quarkus" (Google appends "- Quarkus" when it is omitted from the title.)

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from fa50284 to 5383a4c Compare March 22, 2023 21:50
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 23, 2023

@gsmet Please review and merge.
cc: @sberyozkin

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from 5383a4c to bb103a9 Compare March 23, 2023 10:59
@sberyozkin
Copy link
Member

@rolfedh

The "Security - Quarkus" link (SERP 5) will change to "Security policy - Quarkus" (Google appends "- Quarkus" when it is omitted from the title.)

Sounds good, it will become clearer IMHO, let me approve, but I'd like Guillaume to double check

@sberyozkin sberyozkin self-requested a review March 23, 2023 12:09
@sberyozkin
Copy link
Member

@rolfedh If I press the New Issue button, one of the options there is to link to this file, please check the link will work

@rolfedh rolfedh force-pushed the rename-security-policy-file branch 2 times, most recently from c9000cd to c555c66 Compare March 23, 2023 15:44
@sberyozkin
Copy link
Member

@rolfedh So, just to confirm, does the link which can be found in https://github.com/quarkusio/quarkus/issues/new/choose will work after the file is renamed ?

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from c555c66 to d4bb765 Compare March 23, 2023 18:25
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 23, 2023

@rolfedh So, just to confirm, does the link which can be found in https://github.com/quarkusio/quarkus/issues/new/choose will work after the file is renamed ?

Ah, I see what you mean now. That link is controlled somewhere outside the contents of the repo: Perhaps in the repo settings?
I've updated this MR to so that both SECURITY.md and SECURITY-POLICY.md files are available.
After someone updates the link you've mentioned to point to SECURITY-POLICY.md, we can delete SECURITY.md.

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from d4bb765 to 2f40822 Compare March 23, 2023 18:35
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 23, 2023

After someone updates the link you've mentioned to point to SECURITY-POLICY.md, we can delete SECURITY.md.

@sberyozkin I'll create an issue requesting this update if/when we decide to merge this PR.

@sberyozkin
Copy link
Member

@rolfedh Thanks, Guillaume, @gsmet, can you help with finalizing this PR please, are you OK with the proposed flow - we merge this PR and then delete security.md once the link from the issue template to the sec policy is updated ? Or it can be done right now ? I can't find where is it controlled

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 24, 2023

I can't find where is it controlled

I'm guessing it might be a description field in GitHub the issue templates: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from b2044c0 to e71b704 Compare March 24, 2023 14:03
@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 24, 2023

Or it can be done right now ?

@sberyozkin @gsmet
In any case, this PR must be merged before you can update the link to point to SECURITY-POLICY.md

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 27, 2023

/assign @gsmet

@rolfedh rolfedh force-pushed the rename-security-policy-file branch from e71b704 to b5730cd Compare March 27, 2023 16:32
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not something we can tweak. See https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository .

The SECURITY.md file needs to stay and let's not duplicate it.

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 28, 2023

The SECURITY.md file needs to stay and let's not duplicate it.

Based on this new information, I'll close this PR.

@rolfedh rolfedh closed this Mar 28, 2023
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Mar 28, 2023
@rolfedh rolfedh deleted the rename-security-policy-file branch March 28, 2023 15:46
@sberyozkin
Copy link
Member

Thanks @gsmet, @rolfedh What do you think though about updating not the file name itself but the title of the page, from Security to Security Policy or is quarkusio/quarkusio.github.io#1665 enough ?

@rolfedh
Copy link
Contributor Author

rolfedh commented Mar 29, 2023

Thanks @gsmet, @rolfedh What do you think though about updating not the file name itself but the title of the page, from Security to Security Policy or is quarkusio/quarkusio.github.io#1665 enough ?

The SECURITY.md in this quarkusio repo already has "Security policy" as its title.

PR #1665 fixes Issue #1664 by making the following improvements:

  • Updates the filename and URL path from security.adoc (/security) to security-policy.adoc (/security-policy).
  • Updates the title of that content from "Security" to "Security policy".
  • Updates a link to point to the new URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants