Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Hibernate-related Maven properties to root POM #40964

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 4, 2024

... and automate version parsing for the documentation.

To avoid having to repeat the same version in various places, because
that leads to Yoann just forgetting about it and making a mess.

Based on #40956, which should be merged first.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation labels Jun 4, 2024
Copy link

github-actions bot commented Jun 4, 2024

🙈 The PR is closed and the preview is expired.

... and automate version parsing for the documentation.

To avoid having to repeat the same version in various places, because
that leads to Yoann just forgetting about it and making a mess.
@yrodiere yrodiere force-pushed the automate-hibernate-versions branch from b4e8a17 to ae97308 Compare June 4, 2024 17:03
@yrodiere yrodiere marked this pull request as ready for review June 4, 2024 17:03
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

quarkus-bot bot commented Jun 4, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit ae97308.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jun 4, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit ae97308.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
JVM Tests - JDK 21 Build Failures Logs Raw logs 🔍

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ JVM Tests - JDK 21 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 88 more

📦 extensions/hibernate-orm/deployment

io.quarkus.hibernate.orm.xml.hbm.HbmXmlQuarkusConfigTest. - History - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:708)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
	at io.quarkus.runtime.Application.start(Application.java:101)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:285)

@yrodiere
Copy link
Member Author

yrodiere commented Jun 5, 2024

The JDK 21 test failure is a flake (see quarkusio/quarkus-github-bot#452).

Root cause: java.lang.OutOfMemoryError: Metaspace :/

I don't see how this PR could possibly affect memory usage in tests, so I'd just merge?

And someone will have to look into QuarkusUnitTest memory leaks... again... It's not about dev mode this time, since we recently isolated dev mode tests in a different surefire execution.

@gsmet gsmet merged commit 59fbe75 into quarkusio:main Jun 5, 2024
56 of 69 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 5, 2024
@yrodiere yrodiere deleted the automate-hibernate-versions branch October 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/docstyle issues related for manual docstyle review area/documentation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants