-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Hibernate-related Maven properties to root POM #40964
Conversation
🙈 The PR is closed and the preview is expired. |
... and automate version parsing for the documentation. To avoid having to repeat the same version in various places, because that leads to Yoann just forgetting about it and making a mess.
b4e8a17
to
ae97308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Status for workflow
|
Status for workflow
|
Status | Name | Step | Failures | Logs | Raw logs | Build scan |
---|---|---|---|---|---|---|
✔️ | JVM Tests - JDK 17 | Logs | Raw logs | 🔍 | ||
✖ | JVM Tests - JDK 21 | Build |
Failures | Logs | Raw logs | 🔍 |
Full information is available in the Build summary check run.
You can consult the Develocity build scans.
Failures
⚙️ JVM Tests - JDK 21 #
- Failing: extensions/hibernate-orm/deployment
! Skipped: extensions/flyway/deployment extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 88 more
📦 extensions/hibernate-orm/deployment
✖ io.quarkus.hibernate.orm.xml.hbm.HbmXmlQuarkusConfigTest.
- History - More details - Source on GitHub
java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.test.QuarkusUnitTest.beforeAll(QuarkusUnitTest.java:708)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Caused by: java.lang.RuntimeException: Failed to start quarkus
at io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
at io.quarkus.runtime.Application.start(Application.java:101)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at io.quarkus.runner.bootstrap.StartupActionImpl.run(StartupActionImpl.java:285)
The JDK 21 test failure is a flake (see quarkusio/quarkus-github-bot#452). Root cause: I don't see how this PR could possibly affect memory usage in tests, so I'd just merge? And someone will have to look into |
... and automate version parsing for the documentation.
To avoid having to repeat the same version in various places, because
that leads to Yoann just forgetting about it and making a mess.
Based on #40956, which should be merged first.