Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split creation of the Set to match unknown properties to avoid MethodTooLargeException #44624

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Split creation of the Set to match unknown properties to avoid MethodTooLargeException #44624

merged 1 commit into from
Nov 25, 2024
+72 −57

Conversation

radcortez
Copy link
Member

@radcortez radcortez requested a review from gsmet November 21, 2024 17:56
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 22, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1db73a7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet merged commit 292911c into quarkusio:main Nov 25, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 25, 2024
@gsmet
Copy link
Member

gsmet commented Nov 25, 2024

@radcortez all the reports were with main, right? Or do we try to backport it to 3.17 too?

@radcortez
Copy link
Member Author

All main yes, but this was caused primarily by #44079 which is set to 3.18, but also #44448, which is set to 3.17.

It probably wouldn't hurt to backport, just in case.

@gsmet
Copy link
Member

gsmet commented Nov 25, 2024

OK, thanks, added the label then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/config area/core kind/bugfix triage/backport triage/flaky-test
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.

Build fails with "Method too large" exception
2 participants
@radcortez @gsmet