Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix off-by-one error in exception decoration code #44834

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Fix off-by-one error in exception decoration code #44834

merged 1 commit into from
Nov 30, 2024
+1 −1

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 29, 2024 •
edited
Loading

This was failing only in dev mode when using printf-style logging (%s indexes are 1-based).

Fixes smallrye/smallrye-graphql#2230

@gsmet
Fix off-by-one error in exception decoration code
64f0108 
This was failing only in dev mode when using printf-style logging.

Fixes smallrye/smallrye-graphql#2230
@gsmet gsmet requested a review from dmlloyd November 29, 2024 17:45
@gsmet gsmet mentioned this pull request Nov 29, 2024
Open
dmlloyd
dmlloyd approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. My mistake, apologies. printf is one-based while MessageFormat is zero-based.

@gsmet
Copy link
Member Author

gsmet commented Nov 29, 2024

To be honest, I’m not sure if it’s you or me who introduced the problem as I remember reworking a few things. Anyway, should be better after that.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Nov 29, 2024 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 64f0108.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gastaldi gastaldi merged commit 41ed342 into quarkusio:main Nov 30, 2024
52 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
area/core triage/backport triage/backport-3.15
Projects
None yet
Milestone
3.18 - main
Development

Successfully merging this pull request may close these issues.

Logging error
3 participants
@gsmet @dmlloyd @gastaldi