Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Portuguese translation website #1790

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Conversation

gastaldi
Copy link
Collaborator

@gastaldi gastaldi commented Sep 20, 2023

This includes the Portuguese translated version in the menus

@github-actions
Copy link

github-actions bot commented Sep 20, 2023

🙈 The PR is closed and the preview is expired.

@insectengine
Copy link
Collaborator

@gastaldi - Why is Portuguese above Spanish? You trying to say something here? :P Just kidding, it looks good on my end.

@holly-cummins - Please note the addition to the translation tab in the navigation.

@holly-cummins
Copy link
Contributor

Thanks for the heads-up, @insectengine! I've raised quarkusio/extensions#363, although of course we shouldn't merge until this one merges.

I've also raised quarkusio/extensions#362 to cover both "maybe extending the Poruguese work to the extensions sub-site" and the more general "the subsite doesn't handle being navigated to from the translated sites and it also doesn't really handle navigating to the tranlsated sites very well."

@gastaldi gastaldi marked this pull request as ready for review September 25, 2023 15:00
@gastaldi
Copy link
Collaborator Author

https://pt.quarkus.io/ is now live! Merging this now

@gastaldi gastaldi merged commit 461bffd into quarkusio:develop Sep 25, 2023
@gastaldi gastaldi deleted the pt branch September 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants