Performance page #2122
Performance page #2122
Conversation
|
🙈 The PR is closed and the preview is expired. |
|
+1 to having this page, but I made some suggestions on Jeff Beck's google document that it would be nice to see incorporated here. The version on this PR doesn't mention our excellent throughput, which we need to start talking about. |
|
@holly-cummins - please check this out again as I've updated the content. |
|
Looks good to me, thanks! :) I'm looking forward to using that throughput icon in other places, too. |
|
I'd add an approving review but I don't have the permissions to assign reviewers. |
|
I added some reviews. |
| <img class="dark-only" src="{{site.baseurl}}/assets/images/about/icon-reactive-dark.svg"> | ||
| <h3><a href="/continuum">Reactive Core</a></h3> | ||
| <p>Built on a robust reactive core, Quarkus ensures fast and efficient performance, supporting the development of a wide variety of modern applications.</p> | ||
| <img class="light-only" src="{{site.baseurl}}/assets/images/performance/icon-performance.svg"> |
There was a problem hiding this comment.
I would not have put performance in the second item, on the second line.
I know it's a core strength, but, that's not going to attract lots of developers (otherwise, many languages would not be as popular as they are...).
| <img class="light-only" src="{{site.baseurl}}/assets/images/performance/icon-performance.svg"> | ||
| <img class="dark-only" src="{{site.baseurl}}/assets/images/performance/icon-performance-dark.svg"> | ||
| <h3><a href="/performance">Performance</a></h3> | ||
| <p>Quarkus streamlines framework optimizations in the build phase to reduce runtime dependencies and improve efficiency. By precomputing metadata and optimizing class loading, it ensures fast startup times for JVM and native binary deployments, cutting down on memory usage.</p> |
There was a problem hiding this comment.
Hum, this is semantically equivalent to the last sentence of the container feature.
insectengine
force-pushed
the
PerformancePage
branch
from
1d0cd1b to
b86244b
Compare
|
I feel this is ready for review... 2) Performance Page - Updated content from the doc. 3) Flyout Nav - Added to the "Why" flyout |
|
Where are we with this, @cescoffier? It would be fantastic to get this reviewed and up so we can start getting eyeballs on this important content. |
|
@holly-cummins @insectengine Hey! Sorry, missed the last update. It looks A LOT better. I will do a few suggestion later today:
|
Co-authored-by: Clement Escoffier <[email protected]>
Co-authored-by: Clement Escoffier <[email protected]>
|
@cescoffier, it looks like your suggested changes are now live at https://quarkus-site-pr-2122-preview.surge.sh/performance/ |
|
@holly-cummins not the landing page (order + outdated content). Maybe we can limit this PR to the performance page. |
|
@insectengine Thanks for the update, waiting for the previous (because, no... I'm not reviewing HTML blurb :-)) |
|
@insectengine The content on the landing page is outdated: That's what we have on quarkus.io: |
|
@cescoffier - updated the Reactive title/content for the homepage. |
|
LGTM, @holly-cummins Are you ok? @insectengine maybe squash the commits. 12 commits, that's a bit too much :-) |
|
Yes, squash and go, I think! |
|
@cescoffier - A merge commit blocked any squashing I tried to do. I pulled the changed files into a new branch and submitted a new PR for the Performance page. |
@holly-cummins