-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev UI Homepage Section and Dedicated Page #2178
base: main
Are you sure you want to change the base?
Conversation
Thanks @josephaw1022 - I am looking at it. can you please squash your commits into 1. Thanks :) |
@cescoffier ^^^ f.y.i |
🎊 PR Preview 7a39d75 has been successfully built and deployed to https://quarkus-site-pr-2178-preview.surge.sh
|
@josephaw1022 Looking at https://quarkus-site-pr-2178-preview.surge.sh/version/main/guides/# I can not seem to find the entry point |
As Phillip said, I'm unsure where this page was intended to be accessed. @insectengine, do you have any idea? Also, please squash your commits. |
I can squash the commits later today. The changes are visible on the landing page under features section of the home page for review. This PR is still a work in progress but is at a point where the direction can be evaluated. I want to ensure it aligns with expectations before investing further effort into potentially unwanted changes. @phillip-kruger @cescoffier |
@cescoffier go to https://quarkus-site-pr-2178-preview.surge.sh/ and scroll down then you will see it |
@josephaw1022 we have some extensions that document their part of dev ui in their extension documentation. It might be a good idea to link to them from this new page. Also we need others like @maxandersen and maybe @gsmet to comment on this too. |
9c1e3cd
to
2e531d9
Compare
@phillip-kruger You definitely are correct regarding the links to the pre-existing pages and documentation on extensions and all that. Definitely can add those in later at some point in this PR. |
add dev ui to the homepage add styling for section to the main.scss file images for section and potentially new page fix wording on single card and adjust card styling in general get the html to look somewhat decent. not done but its good enough for now new bare bone html page (nothing in it) dev ui page and its sections add border top to the section add new sections to the dev ui (config, kubernetes yaml, visualize endpoints) consolidate styling for new and existing sections fix wording on single card and adjust card styling in general get the html to look somewhat decent. not done but its good enough for now Sync documentation of main branch Sync working groups format dev ui page the way the other "why" pages are formatted Sync documentation of main branch fill out rest of the sections for dev ui page
0d9a75e
to
17c7473
Compare
Overall a great start to this but I have some comments from my perspective.
|
To-Do Summary Based on Feedback:@insectengine
@phillip-kruger
|
Adding a Dev UI Page and a section to the home page.
Not done, but this is a good starting point
closes #2174