Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a version filter while parsing guides #352

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

marko-bekhta
Copy link
Collaborator

Fixes #351

  • guides content changed a bit, so I've regenerated the samples and adjusted the tests
  • I thought about starting with parsing the versions first and then getting the files by version. But then I thought that since we don't know which type of version it is (new or legacy) from the version file, we'd be checking if one file exists then the other, so here I kept the reading as is and added a version filter to it that should report if the expected version is missing.

@marko-bekhta marko-bekhta force-pushed the feat/use-versions-to-filter branch from ee943c6 to c6fd4a0 Compare November 4, 2024 18:12
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then I thought that since we don't know which type of version it is (new or legacy) from the version file, we'd be checking if one file exists then the other

TBH that's what I was expecting. Simple, but... simple :)

Anyway, LGTM except for one typo. Thanks!

@marko-bekhta marko-bekhta force-pushed the feat/use-versions-to-filter branch from c6fd4a0 to eae77c1 Compare November 5, 2024 08:24
@marko-bekhta
Copy link
Collaborator Author

"reason": "[parent] Data too large, data for [\u003chttp_request\u003e] would be [1030360888/982.6mb], which is larger than the limit of [1020054732/972.7mb], real usage: [1030360888/982.6mb], new bytes reserved: [0/0b], usages [request\u003d0/0b, fielddata\u003d494/494b, in_flight_requests\u003d0/0b]",

😖 it's probably time to look into that issue with the tests we've "patched" here #345 (comment)

@yrodiere
Copy link
Member

yrodiere commented Nov 5, 2024

"reason": "[parent] Data too large, data for [\u003chttp_request\u003e] would be [1030360888/982.6mb], which is larger than the limit of [1020054732/972.7mb], real usage: [1030360888/982.6mb], new bytes reserved: [0/0b], usages [request\u003d0/0b, fielddata\u003d494/494b, in_flight_requests\u003d0/0b]",

😖 it's probably time to look into that issue with the tests we've "patched" here #345 (comment)

This seems unrelated to the patch. You typically get this kind of error in OpenSearch when you send documents that are too large, or too many documents in a single bulk request.
Reducing the bulk size should fix it.

@marko-bekhta marko-bekhta force-pushed the feat/use-versions-to-filter branch from eae77c1 to 17438b7 Compare November 6, 2024 14:14
@yrodiere yrodiere merged commit 49f9e99 into quarkusio:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide the versions to index based on _data/version.yaml
2 participants