port to rtic2 #1098
Triggered via pull request
March 7, 2024 08:25
ryan-summers
ryan-summers
synchronize
#831
Status
Success
Total duration
15s
Artifacts
–
Annotations
5 warnings
|
labeler
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/labeler@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
labeler
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/labeler@v3. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
src/bin/lockin.rs#L247
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> src/bin/lockin.rs:247:41
|
247 | let clock = SystemTimer::new(|| Systick::now().ticks() as u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Systick::now().ticks()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
casting to the same type is unnecessary (`u32` -> `u32`):
src/bin/dual-iir.rs#L209
warning: casting to the same type is unnecessary (`u32` -> `u32`)
--> src/bin/dual-iir.rs:209:41
|
209 | let clock = SystemTimer::new(|| Systick::now().ticks() as u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `Systick::now().ticks()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`:
src/net/mod.rs#L212
warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`
--> src/net/mod.rs:212:61
|
212 | match self.miniconf.handled_update(|path, old, new| {
| _____________________________________________________________^
213 | | settings_path = path.into();
214 | | *old = new.clone();
215 | | Result::<(), &'static str>::Ok(())
216 | | }) {
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions
= note: `#[warn(clippy::blocks_in_conditions)]` on by default
|