-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving serial settings to a separate crate #813
Conversation
@jordens I'm curious to see if you have any thoughts with the current design. It's definitely not perfect, but I think it's at a decent point for now. I'm going to poke at integrating it into Booster to see how it goes. |
* remove hardware/platform specific logic into Platform * reduce dependencies and hardware stuff from serial-settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jordens Some questisons/comments on the design. Overall, I think we're pretty close to being able to publish this as something. Do we want to keep it in the stabilizer repo for now, or split it into (yet another) repo?
Two last comments/discussions left above, but otherwise I think things here are at a nice state. Ping on the question above as well. |
Let's split it once you want to use it on Booster. Is that now? |
Meh, there's no huge rush to move it onto Booster yet, so maybe we just let it live here for the time being. We can break it out into a separate crate when we feel like it's mature enough. |
This PR fixes #808 by creating a new crate for serial settings and storage.
From the serial console: