Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving serial settings to a separate crate #813

Merged
merged 20 commits into from
Nov 21, 2023
Merged

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Nov 15, 2023

This PR fixes #808 by creating a new crate for serial settings and storage.

From the serial console:

Input was empty?

> help
AVAILABLE ITEMS:
  dfu
  service
  reboot
  factory-reset
  list
  get <item>
  set <item> <value>
  help [ <command> ]

> dfu
Reset to DFU is not supported on this device

> service
Service data not available

> list
Available items:
/broker: "test" [default: "mqtt"]
/id: "04-91-62-d2-a8-6f" [default: "04-91-62-d2-a8-6f"]

@ryan-summers
Copy link
Member Author

@jordens I'm curious to see if you have any thoughts with the current design. It's definitely not perfect, but I think it's at a decent point for now. I'm going to poke at integrating it into Booster to see how it goes.

Copy link
Member Author

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordens Some questisons/comments on the design. Overall, I think we're pretty close to being able to publish this as something. Do we want to keep it in the stabilizer repo for now, or split it into (yet another) repo?

serial-settings/src/lib.rs Show resolved Hide resolved
serial-settings/src/lib.rs Outdated Show resolved Hide resolved
serial-settings/src/lib.rs Show resolved Hide resolved
@ryan-summers
Copy link
Member Author

@jordens Some questisons/comments on the design. Overall, I think we're pretty close to being able to publish this as something. Do we want to keep it in the stabilizer repo for now, or split it into (yet another) repo?

Two last comments/discussions left above, but otherwise I think things here are at a nice state. Ping on the question above as well.

@ryan-summers ryan-summers marked this pull request as ready for review November 20, 2023 11:12
@jordens jordens added this pull request to the merge queue Nov 20, 2023
@jordens jordens removed this pull request from the merge queue due to a manual request Nov 20, 2023
@jordens
Copy link
Member

jordens commented Nov 20, 2023

Let's split it once you want to use it on Booster. Is that now?

serial-settings/src/lib.rs Show resolved Hide resolved
@ryan-summers
Copy link
Member Author

Let's split it once you want to use it on Booster. Is that now?

Meh, there's no huge rush to move it onto Booster yet, so maybe we just let it live here for the time being. We can break it out into a separate crate when we feel like it's mature enough.

@jordens jordens enabled auto-merge November 20, 2023 20:34
@jordens jordens added this pull request to the merge queue Nov 21, 2023
Merged via the queue into main with commit 19c6fa6 Nov 21, 2023
8 of 9 checks passed
@jordens jordens deleted the feature/serial-settings-crate branch November 29, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move serial port configuration menu to separate crate
2 participants