Add Positron help topic provider #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
commented
Nov 6, 2024
juliasilge
added a commit
to posit-dev/positron
that referenced
this pull request
Nov 7, 2024
Addresses #4097 Goes together with quarto-dev/quarto#599; the Quarto PR is needed to actually see this work but this PR should be able to be merged on its own. ### QA Notes In a Quarto file, you should be able to use <kbd>F1</kbd> to bring up help for R like so:  This is only working right now for R, because of #5290. When we fix that, we should also confirm it works in a `.qmd` as well.
DavisVaughan
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Looks nice! Approved but also check out #601 before merging (feel free to merge that into this if you agree with my PR over there)
Screen.Recording.2024-11-08.at.4.40.55.PM.mov
* More usefully define `withVirtualDocUri()` * Use `withVirtualDocUri()` in `provideHelpTopic()`
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #580 as well as posit-dev/positron#4097
Goes together with posit-dev/positron#5292 which is what will power this
I did not end up messing with the
quarto-assistwebview at all, since that is a whole separate thing; this is just about sending info to Positron for the Positron Help panel.