Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: x/feemarket #836

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: x/feemarket #836

merged 1 commit into from
Aug 30, 2024

Conversation

ajansari95
Copy link
Contributor

@ajansari95 ajansari95 commented Aug 30, 2024 •
edited
Loading

1. Overview

  • v1.0.x had a bug that was not prededucting fees
  • this fix updates wiring and bumps version
  • refer this.

2. Implementation details

3. How to test/use

4. Checklist

  • Does the Readme need to be updated?

5. Limitations (optional)

6. Future Work (optional)

arhamchordia
arhamchordia approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@arhamchordia arhamchordia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arhamchordia arhamchordia merged commit 5aacc03 into main Aug 30, 2024
6 checks passed
@arhamchordia arhamchordia deleted the fix/feemarket-bug branch August 30, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhamchordia arhamchordia arhamchordia approved these changes

@akure akure Awaiting requested review from akure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajansari95 @arhamchordia