Skip to content

Commit

Permalink
fix(testing): manage undefined value on dev param, fix #216
Browse files Browse the repository at this point in the history
  • Loading branch information
IlCallo committed May 30, 2022
1 parent 6af3ee3 commit b9d5efc
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/testing/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = async function (api) {
api.compatibleWith('quasar', '^2.0.0');

if (api.hasVite) {
api.compatibleWith('@quasar/app-vite', '^1.0.0-beta.8');
api.compatibleWith('@quasar/app-vite', '^1.0.0');
} else if (api.hasWebpack) {
// TODO: should be "@quasar/app-webpack" but that is not backward compatible
// Remove when Qv3 comes out
Expand Down Expand Up @@ -92,12 +92,11 @@ module.exports = async function (api) {
process.exit(hasFailed ? 1 : 0);
};

// If --dev was passed or e2e-webdriver / security-zap tests are being run
// If --dev was passed or security-zap tests are being run
// Cypress already spawns it's dev server
// TODO: use start-test for all harnesses needing quasar devServer running?
if (
args.dev !== null ||
args.e2e.includes('webdriver') ||
(args.dev !== null && args.dev !== undefined) ||
args.security.includes('zap')
) {
// Start dev server
Expand Down

0 comments on commit b9d5efc

Please sign in to comment.