Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade-guide.md #17656

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

CamilleDrapier
Copy link

@CamilleDrapier CamilleDrapier commented Nov 22, 2024

Update the minimum required NodeJs version reminder, based on the previous occurrence

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Update the minimum required NodeJs version reminder, based on the previous occurrence
@rstoenescu
Copy link
Member

Hi,

The min node version is 16 though. Did you encounter issues with 16?

@CamilleDrapier
Copy link
Author

CamilleDrapier commented Nov 22, 2024

Hi,

I have not tried running the dev version of Quasar with Node 16. I thought this was a typo as it is written above that the (new) minimum version will change to 18.12.
But if I misunderstood this, let's close this PR, and I'm sorry for taking your time. Or maybe I targetted the wrong base branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants