Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support julia 1.5 keyword argument syntax: interpret @vlplot(; x, y) as @vlplot(x=x, y=y) #318

Open
lassepe opened this issue Jul 10, 2020 · 1 comment
Milestone

Comments

@lassepe
Copy link

lassepe commented Jul 10, 2020

As of JuliaLang/julia#29333 julia 1.5 supports implicitly named keyword arguments, e.g. f(; x, y) is interpreted as f(; x=x, y=y). It would be nice to support a similar syntax in the @vlplot macro. I at least find myself typing something like @vlplot(:line, width=width, height=height, x=x, y=y) quite often when writing functions that compose a custom spec for which I want to expose some properties as method arguments.

@davidanthoff davidanthoff added this to the Backlog milestone Jul 14, 2020
@davidanthoff
Copy link
Member

We just need to be a bit careful how that interacts with our existing positional arguments. But maybe just allowing this after a semicolon would be one option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants