Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing context ID in datagrams #58

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix missing context ID in datagrams #58

merged 1 commit into from
Aug 20, 2024

Conversation

marten-seemann
Copy link
Member

For UDP payloads, the context ID is 0, see section 5 of RFC 9298.

For UDP payloads, the context ID is 0, see section 5 of RFC 9298.
@marten-seemann marten-seemann linked an issue Aug 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.38%. Comparing base (acf6987) to head (44a8db5).
Report is 1 commits behind head on master.

Files Patch % Lines
conn.go 60.00% 2 Missing and 2 partials ⚠️
proxy.go 60.00% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   73.66%   72.38%   -1.29%     
==========================================
  Files           4        4              
  Lines         300      315      +15     
==========================================
+ Hits          221      228       +7     
- Misses         56       60       +4     
- Partials       23       27       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit 0a64ee9 into master Aug 20, 2024
17 checks passed
@marten-seemann marten-seemann deleted the context-id branch August 20, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse / set the datagram context ID
1 participant