Replace get_named_module with nn.Module.get_submodule #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quic-kyunggeu
requested review from
quic-akhobare,
quic-geunlee and
quic-seokan
quic-kyunggeu
requested review from
quic-hitameht,
quic-klhsieh and
quic-mtuttle
quic-klhsieh
previously approved these changes
Feb 18, 2025
Signed-off-by: Kyunggeun Lee <[email protected]>
quic-kyunggeu
force-pushed
the
use_get_submodule
branch
from
a23e753 to
ad96015
Compare
quic-klhsieh
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
Replaced our custom util function
aimet_torch.utils.get_named_modulewith PyTorch public APInn.Module.get_submodule