Merge pull request #922 from philipwhiuk/qfj-exceptionNotThrowable

Catch `Exception` not `Throwable` in `CompositeLog`
quickfix-j · Jan 3, 2025 · 8bfaf28 · 8bfaf28
2 parents c4a795a + f321670
commit 8bfaf28
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/quickfixj-core/src/main/java/quickfix/CompositeLog.java b/quickfixj-core/src/main/java/quickfix/CompositeLog.java
@@ -40,13 +40,13 @@ public void clear() {
         for (Log log : logs) {
             try {
                 log.clear();
-            } catch (Throwable e) {
+            } catch (Exception e) {
                 handleError(e);
             }
         }
     }
 
-    private void handleError(Throwable e) {
+    private void handleError(Exception e) {
         if (rethrowException) {
             throw new RuntimeException(e);
         }
@@ -57,7 +57,7 @@ public void onIncoming(String message) {
         for (Log log : logs) {
             try {
                 log.onIncoming(message);
-            } catch (Throwable e) {
+            } catch (Exception e) {
                 handleError(e);
             }
         }
@@ -67,7 +67,7 @@ public void onOutgoing(String message) {
         for (Log log : logs) {
             try {
                 log.onOutgoing(message);
-            } catch (Throwable e) {
+            } catch (Exception e) {
                 defaultLog.error(e.getMessage() + ", continuing", e);
             }
         }
@@ -77,7 +77,7 @@ public void onEvent(String text) {
         for (Log log : logs) {
             try {
                 log.onEvent(text);
-            } catch (Throwable e) {
+            } catch (Exception e) {
                 handleError(e);
             }
         }
@@ -87,7 +87,7 @@ public void onErrorEvent(String text) {
         for (Log log : logs) {
             try {
                 log.onErrorEvent(text);
-            } catch (Throwable e) {
+            } catch (Exception e) {
                 handleError(e);
             }
         }